feat: add --profile ci and memoize ciTopology in-process - #765
Merged
Conversation
CLI JSON stays snake_case. Node testsPlan/testsImpact and analyzeProject plan reports now camelize keys, expose optional executionTargets.name, and filter selected tests with includeGlob/--include-glob. Co-authored-by: Cursor <cursoragent@cursor.com>
CLI --profile ci forces unbounded command and lock timeouts. Node profile: \"ci\" is stripped from command JSON, and ciTopology() reuses in-process results keyed by root, config path, and mtime. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
the
documentation
This comment has been minimized.
This comment has been minimized.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Decamelize planJson for comment/graph APIs, camelize testsTargets/testsWhy/ testsGraph results, name Swift prefixes only on Swift runners, and align the declaration tests plus includeGlob docs with testsPlan-only. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
The stacked merge left conflict markers in Agent Defaults; keep both the camelCase TestPlan notes and ciTopology memo / profile ci docs. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
JSON.stringify(testsPlan()) must round-trip through comment/graph APIs, analyzeProject document reports need the same conversion, and testsWhy must not camelize changed-file map keys. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Different workflow filters must not share a cached topology, and Node profile: \"ci\" must clear supplied command and lock deadlines like the CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Saved testsPlan JSON loaded via plan must decamelize like planJson, and analyzeProject must camelize testsTargets, testsGraph, and testsWhy. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Native TestsWhyOptions rejects planJson. Materialize camelCase saved plans to a snake_case temp file and pass that as plan for both standalone and batched why reports. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Batched analyzeProject why reports can share a PID/timestamp filename; mkdtempSync keeps each saved plan isolated. Co-authored-by: Cursor <cursoragent@cursor.com>
Prepare plan documents with fs/promises and always delete mkdtemp dirs after standalone and batched why reports, including native rejections. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Runtime already accepts inline saved plans on testsWhy and batched analyzeProject reports; the types need to match. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep in-process ciTopology memo and profile-ci timeout clearing on top of the merged TestPlan Node contract. Co-authored-by: Cursor <cursoragent@cursor.com>
jonathanong
enabled auto-merge (squash)
August 23, 2026 01:14
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs_coverage matches the inventory header and `| \`name\` |` rows exactly; the padded merge table failed that parser. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Memo keying already uses path.resolve; pass that same root into N-API so a chdir between cache lookup and the native lock cannot serve the wrong tree. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep ciTopology memo and absolute-root native pin on top of the latest postgres-require-query-annotation rule.
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 23, 2026
Keep no-mistakes-config and workflow-topology-policy registered alongside postgres-no-add-column. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--profile cisets--timeout 0 --lock-timeout 0.profile: \"ci\"is stripped from command JSON; omitted Node timeouts stay unbounded.ciTopology()memoizes in-process by resolved root, config path, and mtime, and drops the cache entry on reject.Test plan
ci_profile_disables_timeoutsnapi_profile_ci_is_stripped--profileMade with Cursor
Shepherd Journal